Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 13_0_X (6/N): GRun menu V1.0 of 2023 #41232

Merged
merged 2 commits into from
Mar 31, 2023
Merged

HLT menu development for 13_0_X (6/N): GRun menu V1.0 of 2023 #41232

merged 2 commits into from
Mar 31, 2023

Conversation

missirol
Copy link
Contributor

backport of #41231

PR description:

Development of HLT menus for CMSSW_13_0_X.

This version of the GRun HLT menu corresponds to the "V1.0" menu for 2023 pp data-taking, and the corresponding frozen menu is added to the release.

Note : this PR has one additional change that is specific to the 13_0_X release cycle; the @relval2023 alias is redirected to the 2023-V1.0 frozen menu (as usual for closed releases, the appropriate frozen HLT menu, when available, is used in RelVals wfs).

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2637: [BPH] updated PSs of HLT_SingleEle8_SingleEGL1 trigger
  • CMSHLT-2644: [SUS,EXO,TAU] set PS=0 for Mu3er*MET*70 and MediumChargedIsoPFTau180HighPtRelaxedIso_Trk50_eta2p1 triggers, and remove them from GRun
  • CMSHLT-2645: [ECAL] renamed HLT_Ele35_WPTight_Gsf_L1EGMT_v trigger, and disabled it (PS=0)
  • CMSHLT-2700: [HIG] replaced instances of HLTPFDiJetCorrCheckerWithDiTau with HLTDiPFJetPlusTausCandidatePFJetProducer
  • CMSHLT-2704: [HIG] added PNet-based 4J2B backup trigger with PF-HT cut
  • CMSHLT-2710: [TSG] added PS columns for "HLTPhysics+ZeroBias" and "2p3E34"
  • CMSHLT-2723: [SMP] moved HLT_Photon35_TwoProngs35 trigger to EGamma PD(s)
  • CMSHLT-2724: [EXO] added Mu6HT240*DisplacedDijet backup triggers
  • CMSHLT-2727: [SMP] added Photon+Tau and DiTau triggers for W-rare-decay searches
  • CMSHLT-2728: [PPS] renamed ExpressPPSRandom to DQMPPSRandom stream/PD
  • CMSHLT-2729: [BPH] single PD and stream for ParkingDoubleElectronLowMass
  • CMSHLT-2730: [EXO] control trigger and 2 backups for L1SingleLLP-seeded triggers
  • CMSHLT-2739: [MUO,EXO] set PS=4 for HLT_Mu8_v and HLT_Mu8_TrkIsoVVL_v

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41231

Development of HLT menus for 2023 data-taking and Run-3 MC.

missirol added 2 commits March 30, 2023 13:55
@missirol
HLT menu development for 13_0_X
ba71f15 
Development of HLT menus for `CMSSW_13_0_X`.

This version of the GRun HLT menu corresponds to the "V1.0" menu for 2023 pp data-taking, and the corresponding frozen menu is added to the release.

It includes the integration of the following JIRA tickets.

 - [CMSHLT-2637](https://its.cern.ch/jira/browse/CMSHLT-2637): [BPH] updated PSs of `HLT_SingleEle8_SingleEGL1` trigger
 - [CMSHLT-2644](https://its.cern.ch/jira/browse/CMSHLT-2644): [SUS,EXO,TAU] set PS=0 for `Mu3er*MET*70` and `MediumChargedIsoPFTau180HighPtRelaxedIso_Trk50_eta2p1` triggers, and remove them from GRun
 - [CMSHLT-2645](https://its.cern.ch/jira/browse/CMSHLT-2645): [ECAL] renamed `HLT_Ele35_WPTight_Gsf_L1EGMT_v` trigger, and disabled it (PS=0)
 - [CMSHLT-2700](https://its.cern.ch/jira/browse/CMSHLT-2700): [HIG] replaced instances of `HLTPFDiJetCorrCheckerWithDiTau` with `HLTDiPFJetPlusTausCandidatePFJetProducer`
 - [CMSHLT-2704](https://its.cern.ch/jira/browse/CMSHLT-2704): [HIG] added PNet-based 4J2B backup trigger with PF-HT cut
 - [CMSHLT-2710](https://its.cern.ch/jira/browse/CMSHLT-2710): [TSG] added PS columns for "HLTPhysics+ZeroBias" and "2p3E34"
 - [CMSHLT-2723](https://its.cern.ch/jira/browse/CMSHLT-2723): [SMP] moved `HLT_Photon35_TwoProngs35` trigger to EGamma PD(s)
 - [CMSHLT-2724](https://its.cern.ch/jira/browse/CMSHLT-2724): [EXO] added `Mu6HT240*DisplacedDijet` backup triggers
 - [CMSHLT-2727](https://its.cern.ch/jira/browse/CMSHLT-2727): [SMP] added Photon+Tau and DiTau triggers for W-rare-decay searches
 - [CMSHLT-2728](https://its.cern.ch/jira/browse/CMSHLT-2728): [PPS] renamed `ExpressPPSRandom` to `DQMPPSRandom` stream/PD
 - [CMSHLT-2729](https://its.cern.ch/jira/browse/CMSHLT-2729): [BPH] single PD and stream for `ParkingDoubleElectronLowMass`
 - [CMSHLT-2730](https://its.cern.ch/jira/browse/CMSHLT-2730): [EXO] control trigger and 2 backups for L1SingleLLP-seeded triggers
 - [CMSHLT-2739](https://its.cern.ch/jira/browse/CMSHLT-2739): [MUO,EXO] set PS=4 for `HLT_Mu8_v` and `HLT_Mu8_TrkIsoVVL_v`
@missirol
Move HLT:@relval2023 to frozen 2023-V1.0 pp menu
fe40ddf
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Mar 30, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 30, 2023 •
edited
Loading

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • workflows = 139.004,140.003,140.023,140.043,140.063,12634.0,12634.99,12834.0,13034.0,13034.99

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-714cb4/31688/summary.html
COMMIT: fe40ddf
CMSSW: CMSSW_13_0_X_2023-03-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41232/31688/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4768881
  • DQMHistoTests: Total failures: 127
  • DQMHistoTests: Total nulls: 59
  • DQMHistoTests: Total successes: 4768673
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4853.226 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 12634.0,... ): -383.814 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 12634.0,... ): -49.803 KiB HLT/Filters
  • DQMHistoSizes: changed ( 12634.0,... ): 23.594 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12634.0,... ): 14.171 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12634.0,... ): -4.324 KiB HLT/SMP
  • DQMHistoSizes: changed ( 12634.0,... ): 1.283 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.004,... ): 0.047 KiB HLT/TAU
  • Checked 256 log files, 206 edm output root files, 59 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • changes in the outputs of PR tests are in line with updates to the HLT GRun menu, the update of the @relval2023 alias (from "GRun" ot "2023 V1.0"), and the change in name of the fake and frozen HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor Author

@cms-sw/orp-l2 , kind ping to review this backport. The parent PR tested okay in the latest 13_1_X IBs.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 28e5627 into cms-sw:CMSSW_13_0_X Mar 31, 2023
@missirol missirol deleted the HLTdevelopment130X branch April 2, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
3 participants
@missirol @cmsbuild @perrotta